|
What... the... hell
Is what comes to mind first. Ive been going over the coding for PHPBB's crap, and found a very disturbing piece of code
[php]
$date_forward = create_date('Ymd', $time_now+($board_config['birthday_check_day']*86400), $board_config['board_timezone']);
while ($birthdayrow = $db->sql_fetchrow($result))
{
usleep(2000000);
$user_birthday2 = $this_year.($user_birthday = realdate("md",$birthdayrow['user_birthday'] ));
if ( $user_birthday2 < $date_today ) $user_birthday2 += 10000;
if ( $user_birthday2 > $date_today && $user_birthday2 <= $date_forward )
[/php]
I honestly could not tell you why it is there, but take a look at that usleep(2000000) right in the middle of that while loop... That was executing a 2 SECOND DELAY on page load FOR EVERY BIRTHDAY that was happening any given day!
Meaning quite simply, on a day with 3 birthdays, there would be a total of 6 seconds before the page was displayed, on top of the normal rendering procedures going on!
After taking out that usleep, BAM, no more retarded site slowdown!
Any webmasters using PHPBB, please review your index.php for this code and FIX IT!
_________________ Through Honor We Achieve: Immortality
|